fix(nextjs): Add new potential location for Next.js request AsyncLocalStorage #9006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Sep 12, 2023
| @@ -1,3 +1,3 @@ | |||
| export async function PUT() { | |||
| export async function PUT(): Promise<Response> { | |||
There was a problem hiding this comment.
For some reason the new version wants types here. I think nextjs has some kind of ts plugin that checks for this.
mydea
approved these changes
Sep 12, 2023
lforst
force-pushed
the
lforst-fix-async-storage
branch
from
fb327d0 to
e27c44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8977
Next.js moved the internal file we depend on to grab headers of incoming request so we need to check the new location.