Skip to content

Update tracekit.js to include webpack stacktrace #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2017
Merged

Update tracekit.js to include webpack stacktrace #908

merged 2 commits into from
Mar 27, 2017

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Mar 26, 2017 •
edited
Loading

@benvinegar benvinegar mentioned this pull request Mar 26, 2017
Closed
@benvinegar
Copy link
Contributor Author

Arguably should have tests for Firefox and Safari, but it doesn't affect existing tests for those browsers so ... shrug.

MaxBittker
MaxBittker approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@MaxBittker MaxBittker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@benvinegar benvinegar merged commit 7363eec into master Mar 27, 2017
@benvinegar benvinegar deleted the pr/903 branch March 27, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LewisJEllis LewisJEllis Awaiting requested review from LewisJEllis

1 more reviewer

@MaxBittker MaxBittker MaxBittker approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benvinegar @MaxBittker @RahavLussato