Skip to content

fix(node): Remove ANR debug option and instead add logger.isEnabled() #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(node): Remove ANR debug option and instead add logger.isEnabled() #9230

merged 1 commit into from
Oct 12, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 12, 2023

A separate debug option for enableAnrDetection is confusing and is not required if we add an isEnabled() function to the logger.

@AbhiPrasad AbhiPrasad merged commit f60f763 into getsentry:develop Oct 12, 2023
@timfish timfish deleted the fix/simplify-anr-debug branch December 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad