Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Strictly validate tunnel target parameters #9415

Merged
merged 1 commit into from Oct 31, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 31, 2023

No description provided.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 77.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 66.49 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.97 KB (0%)
@sentry/browser - Webpack (gzipped) 21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.79 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.09 KB (+0.45% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.23 KB (+0.48% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 216.85 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.28 KB (+0.5% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.28 KB (+0.7% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.8 KB (+0.19% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 77.82 KB (0%)
@sentry/react - Webpack (gzipped) 21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 94.15 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 47.86 KB (0%)

@lforst lforst merged commit ddbda3c into develop Oct 31, 2023
54 checks passed
@lforst lforst deleted the lforst-stricter-tunnel-checking branch October 31, 2023 08:11
@dominikjasek
Copy link

🍿

@hueypeard
Copy link

Is it obvious what the impact of this is? Are there any attackers utilising this in the wild? I understand it is probably not a great design choice and the validation should have been stronger, but it would be great to get an idea of exposure

@sreetamdas
Copy link
Contributor

@lforst
Copy link
Member Author

lforst commented Nov 10, 2023

@hueypeard Seconding what @sreetamdas mentioned. We wrote up an FAQ with everything we could think of that might be relevant to the vulnerability. If you're still missing information, let us know how we can improve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants