Skip to content

ref(replay): Add further logging to network body parsing #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

ref(replay): Add further logging to network body parsing #9566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/replay/src/coreHandlers/util/networkUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ export function getBodyString(body: unknown): string | undefined {
__DEBUG_BUILD__ && logger.warn('[Replay] Failed to serialize body', body);
}

__DEBUG_BUILD__ && logger.info('[Replay] Skipping network body because of body type', body);

return undefined;
}

Expand Down
13 changes: 11 additions & 2 deletions packages/replay/src/coreHandlers/util/xhrUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,24 @@ function getResponseHeaders(xhr: XMLHttpRequest): Record<string, string> {
}

function _getXhrResponseBody(xhr: XMLHttpRequest): string | undefined {
// We collect errors that happen, but only log them if we can't get any response body
const errors: unknown[] = [];

try {
return xhr.responseText;
} catch {} // eslint-disable-line no-empty
} catch (e) {
errors.push(e);
}

// Try to manually parse the response body, if responseText fails
try {
const response = xhr.response;
return getBodyString(response);
} catch {} // eslint-disable-line no-empty
} catch (e) {
errors.push(e);
}

__DEBUG_BUILD__ && logger.warn('[Replay] Failed to get xhr response body', ...errors);

return undefined;
}