feat(core): Add getIsolationScope() method
#9957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure to actually export `getGlobalScope()` everywhere as well. The isolation scope, currently, lies on the hub, and is applied to all events.
size-limit report 📦
|
anonrig
reviewed
Dec 21, 2023
Comment on lines
+201
to
+203
| public getIsolationScope(): Scope { | ||
| return this._isolationScope; | ||
| } |
There was a problem hiding this comment.
Shouldn't this be a getter?
There was a problem hiding this comment.
we don't really have getters there right now, also this is really just a very short-lived thing anyhow and will be gone by v8 😅
AbhiPrasad
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure to actually export
getGlobalScope()everywhere as well.The isolation scope, currently, lies on the hub, and is applied to all events.