-
-
Notifications
You must be signed in to change notification settings - Fork 192
ref: crashpad: pre-generate crash event ID #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
added a commit
that referenced
this pull request
Jul 20, 2025
vaind
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the name of the new function
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
approved these changes
Jul 21, 2025
jpnurmi
added a commit
that referenced
this pull request
Jul 21, 2025
JoshuaMoelans
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor nit on adding a more clarifying docstring
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-generate an event ID for a potential future crash on the client side to be able to associate feedback with the crash event at the time of the crash. Extracted from #1303.
Before, Crashpad events (
__sentry-event
) were sent without ID. Even if the server generated an ID on demand and sent it as a response, it was too late for the upcoming feedback handler / crash reporter (#1223). It needs an ID before the event is sent because the user might not give consent to send anything at all.Before
msgpack2json -p -i <run>/__sentry-event
After
msgpack2json -p -i <run>/__sentry-event