test_logs_attributes fails

[MeggyCal]

How do you use Sentry?

Self-hosted/on-premise

Version

2.39.0

Steps to Reproduce

Hi, thank you for maintaining sentry! I am a packager in openSUSE, I was trying to package new version of sentry-sdk, but I got hit by an error:

[  106s] =================================== FAILURES ===================================
[  106s] _____________________________ test_logs_attributes _____________________________
[  106s] tests/test_logs.py:233: in test_logs_attributes
[  106s]     assert "sentry.release" in logs[0]["attributes"]
[  106s] E   assert 'sentry.release' in {'attr_int': 1, 'attr_float': 2.0, 'attr_bool': True, 'attr_string': 'string attribute', 'sentry.message.parameter.my_var': 'some value', 'sentry.message.template': "The recorded value was '{my_var}'", 'sentry.sdk.name': 'sentry.python.django', 'sentry.sdk.version': '2.39.0', 'server.address': 'test-server', 'sentry.environment': 'production', 'sentry.severity_number': 13, 'sentry.severity_text': 'warn'}

Sadly, I have no clue as what could be the problem, version 2.20.0 was ok with the same dependencies. Could you please help me out?

Expected Result

tests should pass

Actual Result

tests fail

[linear]

PY-1869

[sentrivana]

Hey @MeggyCal, thanks for packaging the SDK for openSUSE, we appreciate your work! ❤️

How are you running the test suite?

FWIW I think we can just get rid of the failing assert, it doesn't seem relevant for that particular test case. Let me take a look.

[sentrivana]

One more question, is that the only failure from the whole test run or was the test run terminated when the failure occurred? Wondering whether more tests might have the same issue or if we know for sure it's only test_logs_attributes.

[sentrivana]

Merged #4879 which should fix the failing test -- we'll make a release next week.