Skip to content

Replace Travis CI badge with GitHub Actions badge #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Replace Travis CI badge with GitHub Actions badge #1538

merged 2 commits into from
Aug 4, 2022

Conversation

153957
Copy link
Contributor

@153957 153957 commented Aug 4, 2022

Travis CI is no longer being used and has been replaced by GitHub Actions.
The ci.yml workflow contains the main tests, so show that status in the README.

Travis CI is no longer being used and has been replaced by GitHub Actions.
The ci.yml workflow contains the main tests, so show that status in the README.
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @153957

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) August 4, 2022 09:19
@153957
Copy link
Contributor Author

153957 commented Aug 4, 2022

@sl0thentr0py there is still a 'reference' to travis in the actual ci.yml file, creating postgres databases, maybe those should also be renamed? Or removed if they are not even used, I found not other uses of those database names in the code ( https://github.com/getsentry/sentry-python/search?q=travis_ci_test )

https://github.com/getsentry/sentry-python/blob/master/.github/workflows/ci.yml#L98-L99

@sl0thentr0py sl0thentr0py disabled auto-merge August 4, 2022 09:30
@sl0thentr0py
Copy link
Member

hmm yea don't see where they're used, can you remove them? let's see if CI passes. Thanks again!

These database names do not appear anywhere else in the code and seem unused.
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) August 4, 2022 10:00
@sl0thentr0py sl0thentr0py merged commit 7815a5e into getsentry:master Aug 4, 2022
@153957 153957 deleted the patch-1 branch August 4, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants