Skip to content

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Sep 28, 2022

Our python sdk is the only sdk which sends truncated desc from the sdk side. This effects our ability to cleanly detect perf issues, but in general we should probably aim for more consistency. This bumps the max limit by a moderate amount (again, other sdk's are already sending unbounded data). We could potentially go higher (2048?). Partially put this up for RFC, but if this is fine then I'll fix tests where required and merge it in.

Our python sdk is the only sdk which sends truncated desc from the sdk side. This effects our ability to cleanly detect perf issues, but in general we should probably aim for more consistency. This bumps the max limit by a moderate amount (again, other sdk's are already sending unbounded data). We could potentially go higher (`2048`?). Partially put this up for RFC, but if this is fine then I'll fix tests where required and merge it in.
@sl0thentr0py sl0thentr0py force-pushed the ref/perf-issues-increase-description-max-size branch from 1a71512 to 95a4058 Compare September 29, 2022 13:20
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) September 29, 2022 13:22
@sl0thentr0py sl0thentr0py merged commit dd294be into master Sep 29, 2022
@sl0thentr0py sl0thentr0py deleted the ref/perf-issues-increase-description-max-size branch September 29, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants