Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumenter config to switch between Otel and Sentry instrumentation. #1766



Copy link

No description provided.

sentry_sdk/ Outdated Show resolved Hide resolved
sentry_sdk/ Show resolved Hide resolved
sentry_sdk/ Show resolved Hide resolved
sentry_sdk/ Outdated Show resolved Hide resolved
@sl0thentr0py sl0thentr0py changed the base branch from master to antonpirker/1687-basic-otel-support-1-preparations November 30, 2022 13:46
Base automatically changed from antonpirker/1687-basic-otel-support-1-preparations to master November 30, 2022 15:22
* Api for setting arbitrary contexts in transactions.
* Add parameter to set `start_timestamp` and `end_timestamp`  on Span creation or finishing
… into antonpirker/1687-basic-otel-support-2-instrumenter
Copy link

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests are in another PR, it's fine, otherwise please add some tests for checking that the no-ops work correctly

@antonpirker antonpirker merged commit 46697dd into master Dec 1, 2022
142 checks passed
@antonpirker antonpirker deleted the antonpirker/1687-basic-otel-support-2-instrumenter branch December 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants