Skip to content

doc: Use .venv (not .env) as a virtual env location in CONTRIBUTING.md #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

doc: Use .venv (not .env) as a virtual env location in CONTRIBUTING.md #1790

merged 2 commits into from
Jan 3, 2023

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Dec 19, 2022

.venv is what we use in Makefile, and also .env is not in .gitignore at the moment.

@tonyo tonyo requested a review from antonpirker December 19, 2022 11:33
@sl0thentr0py sl0thentr0py merged commit 55b2902 into master Jan 3, 2023
@sl0thentr0py sl0thentr0py deleted the tonyo/fix-readme-venv-docs branch January 3, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyo @sl0thentr0py