Avoid import of pkg_resource with Starlette integration #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing the order in the condition, we can avoid the call to `_get_installed_modules` (which imports `pkg_resources`) when the `mechanism_type` is set to `"starlette"`.
antonpirker
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
By changing the order in the condition, we can avoid the call to
_get_installed_modulesat import time (which importspkg_resources) when themechanism_typeis set to"starlette".I have validated the change using
PYTHONPROFILEIMPORTTIME=1.Tell me if such a change requires a link to an issue or some testing.