Send all events to /envelope endpoint when tracing is enabled #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
reviewed
Apr 12, 2023
HazAT
previously requested changes
Apr 12, 2023
…ts-when-performance-enabled
sl0thentr0py
approved these changes
Apr 13, 2023
…ts-when-performance-enabled
HazAT
approved these changes
Apr 14, 2023
This was referenced Apr 14, 2023
…ts-when-performance-enabled
…ts-when-performance-enabled
antonpirker
deleted the
antonpirker/2008-use-envelope-for-all-events-when-performance-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracing is enabled we can safely send all events to
/envelope. The dynamic sampling context (DSC) is sent with all envelopes.The legacy
/storeendpoint will be removed in the future.Fixes #2008