Wrap parse_url
calls in capture_internal_exceptions
#2162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2160
Our URL parsing and sanitizing can fail. If it does, the error must never break the user's application.
This PR:
parse_url
incapture_internal_exceptions
and skips setting any parsed URL related data on the span (affects thestdlib
,boto3
,httpx
integrations)sanitize_url
function withsplit=True