Skip to content

fix: Allow int keys in extra dict #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

vladlutkov
Copy link
Contributor

If I pass dict with int keys in extra keyword argument

logger.warning('test', extra={1:1})

I'll get an exception and event will not be sent.

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Could you add one test in test_logging.py?

@vladlutkov
Copy link
Contributor Author

I added a test

@untitaker
Copy link
Member

Sorry but could you run make format and make lint on this? It's not properly formatted. For more information see CONTRIBUTING.md

@untitaker untitaker self-assigned this Jul 11, 2019
@untitaker untitaker merged commit 880b860 into getsentry:master Jul 11, 2019
@untitaker
Copy link
Member

Thanks! Do you need a release for this right now or is this just something you happened to come by?

@vladlutkov
Copy link
Contributor Author

vladlutkov commented Jul 12, 2019

Thanks, I'm ready to wait until the next release.
Off-topic
Does the library only support python 3 and higher?
I did not find it in the documentation.

@untitaker
Copy link
Member

untitaker commented Jul 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants