Skip to content

Beam integration #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2019
Merged

Beam integration #446

merged 4 commits into from
Aug 9, 2019

Conversation

tiopi
Copy link
Contributor

@tiopi tiopi commented Aug 1, 2019 •
edited
Loading

Beam integration requires #439. New files include beam.py, test_beam.py and test additions to tox.

@tiopi tiopi requested review from mitsuhiko and untitaker August 1, 2019 20:06
@tiopi tiopi force-pushed the beam-integration branch from af37dee to 76f7161 Compare August 1, 2019 20:22
@tiopi tiopi requested a review from mikeclarke August 1, 2019 20:23
@tiopi tiopi changed the title Beam integration Merge After Client Pickles Beam integration Aug 1, 2019
@tiopi tiopi force-pushed the beam-integration branch from 3881a4b to f11bbc2 Compare August 2, 2019 17:29
@tiopi tiopi requested review from tkaemming and Zylphrex August 2, 2019 17:31
Zylphrex
Zylphrex reviewed Aug 2, 2019
View reviewed changes
untitaker
untitaker reviewed Aug 6, 2019
View reviewed changes
untitaker
untitaker requested changes Aug 6, 2019
View reviewed changes
@tiopi tiopi force-pushed the beam-integration branch from 3cb98b3 to f809fff Compare August 9, 2019 08:28
@tiopi tiopi force-pushed the beam-integration branch from f809fff to 80260b4 Compare August 9, 2019 08:29
@tiopi tiopi requested a review from untitaker August 9, 2019 08:30
untitaker
untitaker approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make format and fix any other linting issues that make lint gives you, otherwise lgtm

@tiopi tiopi merged commit c8a1be9 into master Aug 9, 2019
@Zylphrex Zylphrex mentioned this pull request Aug 9, 2019
Closed
@Zylphrex Zylphrex deleted the beam-integration branch October 21, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zylphrex Zylphrex Zylphrex left review comments

@untitaker untitaker untitaker approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

@mikeclarke mikeclarke Awaiting requested review from mikeclarke

@tkaemming tkaemming Awaiting requested review from tkaemming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiopi @untitaker @Zylphrex