ref: Use atexit only in init #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
Sep 1, 2018
sentry_sdk/consts.py
Outdated
| import socket | ||
|
|
||
|
|
||
| def default_shutdown_callback(pending, timeout): |
There was a problem hiding this comment.
What is the usecase for making this function configurable?
untitaker
approved these changes
Sep 1, 2018
| @@ -523,9 +523,11 @@ def strip_string(value, assume_length=None, max_length=512): | |||
| return value[:max_length] | |||
|
|
|||
|
|
|||
| logger = logging.getLogger("sentry.errors") | |||
| logger = logging.getLogger("sentry_sdk.errors") | |||
|
Good loop :)
…On Sat, Sep 1, 2018 at 5:53 PM Markus Unterwaditzer < ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In sentry_sdk/utils.py
<#45 (comment)>
:
> @@ -523,9 +523,11 @@ def strip_string(value, assume_length=None, max_length=512):
return value[:max_length]
-logger = logging.getLogger("sentry.errors")
+logger = logging.getLogger("sentry_sdk.errors")
😬
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAc5DACcTRwlzfBFdLo3Jrit1c1rpDsks5uWq2RgaJpZM4WVzXB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same logic as the old raven python background worker which is to block in the atexit running thread on the lock the background worker has. This way the demon thread can be kept alive a while longer to orderly start the shutdown.