Skip to content

feat: Added requests support #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions sentry_sdk/integrations/requests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
from __future__ import absolute_import

from sentry_sdk import add_breadcrumb
from . import Integration

from .logging import ignore_logger


class RequestsIntegration(Integration):
identifier = "requests"

def __init__(self):
from requests.sessions import Session

self.session_cls = Session

def install(self):
real_send = self.session_cls.send

def send(self, request, *args, **kwargs):
def _record_request(response):
add_breadcrumb(
type="http",
category="requests",
data={
"url": request.url,
"method": request.method,
"status_code": response is not None
and response.status_code
or None,
"reason": response is not None and response.reason or None,
},
)

try:
resp = real_send(self, request, *args, **kwargs)
except Exception:
_record_request(None)
raise
else:
print("here", resp)
_record_request(resp)
return resp

self.session_cls.send = send
ignore_logger("requests.packages.urllib3.connectionpool")
26 changes: 26 additions & 0 deletions tests/integrations/requests/test_requests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import pytest

requests = pytest.importorskip("requests")

from sentry_sdk import capture_message
from sentry_sdk.integrations.requests import RequestsIntegration


def test_crumb_capture(sentry_init, capture_events):
sentry_init(integrations=[RequestsIntegration()])
events = capture_events()

response = requests.get("https://httpbin.org/status/418")
assert response.status_code == 418
capture_message("Testing!")

event, = events
crumb, = event["breadcrumbs"]
assert crumb["type"] == "http"
assert crumb["category"] == "requests"
assert crumb["data"] == {
"url": "https://httpbin.org/status/418",
"method": "GET",
"status_code": 418,
"reason": "I'M A TEAPOT",
}
3 changes: 3 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ envlist =

{pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-flask-{1.0,0.11,0.12,dev}

{py2.7,py3.7}-requests
{pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-celery-4
{pypy,py2.7}-celery-3

Expand All @@ -43,6 +44,7 @@ deps =
flask-dev: git+https://github.com/pallets/flask.git#egg=flask
celery-3: Celery>=3.1,<4.0
celery-4: Celery>=4.0,<5.0
requests: requests>=2.0<3.0
flask: flask-login
linters: black
linters: flake8
Expand All @@ -52,6 +54,7 @@ setenv =
django: TESTPATH=tests/integrations/django
flask: TESTPATH=tests/integrations/flask
celery: TESTPATH=tests/integrations/celery
requests: TESTPATH=tests/integrations/requests
usedevelop = True
extras =
flask: flask
Expand Down