-
Notifications
You must be signed in to change notification settings - Fork 562
feat: Add action to run toxgen periodically #4805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added some minor, optional suggestions for tweaks. Feel free to use or ignore :)
workflow_dispatch: | ||
schedule: | ||
# early Monday morning | ||
- cron: '23 3 * * 1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly at 03:23 UTC? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason for this specific time, the important part is just that it's not at :00 -- usually it's good practice to set crons to run at a different time than the start of the hour since that's when most cron jobs are running and yours might be delayed or even dropped. See also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh – perhaps I should change the time I am using in Sentry CLI then
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Description
Run
scripts/generate-test-files.sh
in a GitHub action every Monday morning and create a PR with the changes. If there are already any toxgen PRs open, close them.Here's an example run of the action: https://github.com/sentrivana/sentry-python/actions/runs/17768312844 (from a fork of the repo so that I can test it)
And an example PR: sentrivana#6
Action shamelessly stolen and adapted from sentry-cli. 🥔
Issues
Closes #4050
Reminders
tox -e linters
.feat:
,fix:
,ref:
,meta:
)