Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 16, 2025

Description

Run scripts/generate-test-files.sh in a GitHub action every Monday morning and create a PR with the changes. If there are already any toxgen PRs open, close them.

Here's an example run of the action: https://github.com/sentrivana/sentry-python/actions/runs/17768312844 (from a fork of the repo so that I can test it)
And an example PR: sentrivana#6

Action shamelessly stolen and adapted from sentry-cli. 🥔

Issues

Closes #4050

Reminders

Copy link

codecov bot commented Sep 16, 2025

✅ All tests passed

@sentrivana sentrivana marked this pull request as ready for review September 16, 2025 14:03
@sentrivana sentrivana requested a review from a team as a code owner September 16, 2025 14:03
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added some minor, optional suggestions for tweaks. Feel free to use or ignore :)

workflow_dispatch:
schedule:
# early Monday morning
- cron: '23 3 * * 1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly at 03:23 UTC? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason for this specific time, the important part is just that it's not at :00 -- usually it's good practice to set crons to run at a different time than the start of the hour since that's when most cron jobs are running and yours might be delayed or even dropped. See also here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh – perhaps I should change the time I am using in Sentry CLI then

sentrivana and others added 2 commits September 17, 2025 08:55
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@sentrivana sentrivana enabled auto-merge (squash) September 17, 2025 07:08
@sentrivana sentrivana merged commit 875ed89 into master Sep 17, 2025
140 of 142 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/auto-pr branch September 17, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GH action to run toxgen script periodically and have it submit a PR

2 participants