Skip to content

Conversation

sentrivana
Copy link
Contributor

Description

The toxgen PR template contains links to files in the repo, but they were broken, fixing that here.

Issues

Reminders

@sentrivana sentrivana marked this pull request as ready for review September 17, 2025 09:54
@sentrivana sentrivana requested a review from a team as a code owner September 17, 2025 09:54
_____________________
_🤖 This PR was automatically created using [a GitHub action](.github/workflows/update-tox.yml)._`.replace(/^ {16}/gm, '')
_🤖 This PR was automatically created using [a GitHub action](https://github.com/getsentry/sentry-python/blob/master/.github/workflows/update-tox.yml)._`.replace(/^ {16}/gm, '')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: GitHub URLs Break in Forks and Renamed Repos

The PR body's GitHub URLs are hardcoded with specific repository details and the "master" branch. This makes the links incorrect or broken when the workflow runs in a fork, the repository is renamed, or the default branch is not "master".

Fix in Cursor Fix in Web

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.52%. Comparing base (bc990db) to head (ecb5bc5).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4807      +/-   ##
==========================================
- Coverage   84.55%   84.52%   -0.04%     
==========================================
  Files         158      158              
  Lines       16513    16513              
  Branches     2866     2866              
==========================================
- Hits        13963    13958       -5     
- Misses       1703     1708       +5     
  Partials      847      847              

see 1 file with indirect coverage changes

@sentrivana sentrivana merged commit 6c2a996 into master Sep 17, 2025
128 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/fix-pr-links branch September 17, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants