fix(openai-agents): Move _set_agent_data call to ai_client_span function #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constantinius
deleted the
constantinius/fix/openai-agents/early-chat-agent-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can set the agent data early, so that we get input model and other data, even if there's an exception while running the agent
Issues
Resolves: TET-1205
Note
Move
_set_agent_datatoai_client_spanso agent/model metadata is recorded when the span is created.sentry_sdk/integrations/openai_agents/spans/ai_client.py):ai_client_spanvia_set_agent_dataat span creation._set_agent_datafromupdate_ai_client_spanto avoid duplication.Written by Cursor Bugbot for commit 27e94cc. This will update automatically on new commits. Configure here.