Skip to content

feat(scopes): Explicit scopes #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

feat(scopes): Explicit scopes #633

merged 2 commits into from
Mar 11, 2020

Conversation

mitsuhiko
Copy link
Contributor

This is a draft of the proposal for explicit scope passing.

@HazAT
Copy link
Member

HazAT commented Mar 11, 2020

I think this is fine, we have something similar in iOS right now

Passing explicit scope:
https://github.com/getsentry/sentry-cocoa/blob/cc5bbf39eb8e9f112a9cb82986e15289f471da43/Example/Example/ViewController.swift#L49-L55

Scope Callback:
https://github.com/getsentry/sentry-cocoa/blob/cc5bbf39eb8e9f112a9cb82986e15289f471da43/Example/Example/ViewController.swift#L39-L44

@mitsuhiko mitsuhiko requested a review from untitaker March 11, 2020 10:09
@mitsuhiko mitsuhiko marked this pull request as ready for review March 11, 2020 10:09
untitaker
untitaker approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ftr I still don't like the idea of doing this at all. I believe passing hubs would be the correct solution.

@mitsuhiko mitsuhiko merged commit e680a75 into master Mar 11, 2020
@mitsuhiko mitsuhiko deleted the feature/explicit-scopes branch March 11, 2020 11:19
@HazAT HazAT mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsuhiko @HazAT @untitaker