fix: String keys #90
Merged
fix: String keys #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already works fine right now because the JSON encoder coerces dictionary keys to strings, but we shouldn't rely on this behavior.
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 68.39% 68.39%
=======================================
Files 24 24
Lines 2063 2063
Branches 280 280
=======================================
Hits 1411 1411
Misses 543 543
Partials 109 109
Continue to review full report at Codecov.
|
mitsuhiko
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.