Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Update integration to new JS interface #3814

Merged
merged 8 commits into from
May 13, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented May 13, 2024

📢 Type of change

  • Enhancement
  • Refactoring

📜 Description

Updates the React Native integrations to use the new factory functions returning plain JS object style.

Re-exports all currently used integrations from the root namespace for easier use and to align with browser JS SDK.

💡 Motivation and Context

The Class integrations will be removed in JS SDK V8.

💚 How did you test it?

ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented May 13, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 94b227c

Copy link
Contributor

github-actions bot commented May 13, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 638.58 ms 678.48 ms 39.90 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
6e8584e 447.10 ms 474.71 ms 27.61 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
2534337 394.15 ms 415.12 ms 20.97 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
0677344 327.74 ms 337.14 ms 9.40 ms
5446992 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB

Copy link
Contributor

github-actions bot commented May 13, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 371.12 ms 393.18 ms 22.06 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@krystofwoldrich krystofwoldrich merged commit 9eddef8 into main May 13, 2024
58 of 61 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-update-integrations-backwards-compatible branch May 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants