ref: Rewrite tracing integration in terms of manual API (NATIVE-312) #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hand-rolling all the transaction/span manipulation, rather implement it on top of the manual performance monitoring API. Currently lacks the ability to attach additional `data` to a span.
Swatinem
force-pushed
the
ref/tracing-perf
branch
from
c622bf1
to
9397197
Compare
loewenheim
approved these changes
Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 81.81% 83.40% +1.59%
==========================================
Files 70 70
Lines 7878 7725 -153
==========================================
- Hits 6445 6443 -2
+ Misses 1433 1282 -151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hand-rolling all the transaction/span manipulation, rather implement it on top of the manual performance monitoring API.