Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make building without client feature work again #416

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

Swatinem
Copy link
Member

We weren't testing this in CI previously. And it would seem that this was broken
in the monorepo anyway, since it requires resolver = "2" in order not to unify
features.

supercedes #415, as we still want the API (and trace propagation via headers) to work in such cases.

We weren't testing this in CI previously. And it would seem that this was broken
in the monorepo anyway, since it requires `resolver = "2"` in order not to unify
features.
@codecov-commenter
Copy link

Codecov Report

Merging #416 (19495a8) into master (c75d62a) will increase coverage by 0.24%.
The diff coverage is 83.07%.

❗ Current head 19495a8 differs from pull request most recent head f8e2fe3. Consider uploading reports for the commit f8e2fe3 to get more accurate results

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   82.37%   82.62%   +0.24%     
==========================================
  Files          70       70              
  Lines        7950     7983      +33     
==========================================
+ Hits         6549     6596      +47     
+ Misses       1401     1387      -14     

@Swatinem Swatinem merged commit b3d92a4 into master Jan 24, 2022
@Swatinem Swatinem deleted the fix/no-client branch January 24, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants