fix: Consume Cocoa SDK as .xcframework
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry-unity into feat/ios/xcframework
bitsandfoxes
commented
Oct 13, 2022
Comment on lines
+162
to
+163
| <Message Importance="High" Text="Creating xcconfig file to enable Bitcode." /> | ||
| <WriteLinesToFile File="$(SentryCocoaRoot)unity.xcconfig" Lines="ENABLE_BITCODE = YES" Overwrite="true" /> |
There was a problem hiding this comment.
The Cocoa builds with Bitcode disabled by default. Unity Xcode projects have Bitcode enabled by default. Bitcode has been deprecated but while we wait for Unity to update the generation we build the Cocoa SDK with a temporary config file to enable it.
bitsandfoxes
commented
Oct 13, 2022
Comment on lines
+29
to
+30
| # Override the generated GUID as part of the .bcsymbolmap | ||
| $snapshotContent = $snapshotContent -replace "BCSymbolMaps\/.+?(\.)","BCSymbolMaps/*." |
There was a problem hiding this comment.
Filtering here, since Bitcode is now part of the .xcframework and the Guid changes with every build.
bitsandfoxes
commented
Oct 13, 2022
vaind
approved these changes
Oct 13, 2022
| <Exec WorkingDirectory="$(SentryCocoaRoot)" Command="carthage build --use-xcframeworks --no-skip-current --platform iOS"></Exec> | ||
| <!-- Workaround to enable building the Cocoa SDK with Bitcode enabled --> | ||
| <Message Importance="High" Text="Creating xcconfig file to enable Bitcode." /> | ||
| <WriteLinesToFile File="$(SentryCocoaRoot)unity.xcconfig" Lines="ENABLE_BITCODE = YES" Overwrite="true" /> |
There was a problem hiding this comment.
what happens if we have it enabled here and users want to disable it (in Unity) - would everything work normally? Just checking because nothing coming from xcode would surprise me
There was a problem hiding this comment.
Yes. I did test that and Xcode just rolls with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we build the Cocoa SDK and then copy the device and simulator
.frameworkdirectories into the Plugins/iOS folder. They get excluded from Unity through the.metafiles because, for the generated XCode project, we set the SDK up ourselves.On the M1 the Carthage build artifacts are named slightly different which breaks our hardcoded paths within the
.xcframework.Since we're currently setting the
.frameworksup to be ignored anyway and we manually copy them to the generated Xcode project, the idea here is:.xcframeworkinstead of the individual.frameworkinto the plugins folder~to it so Unity ignores it (and does not copy the frameworks from within during XCode generation)