Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added MinimumBreadcrumbLevel #1030

Merged
merged 8 commits into from
Oct 24, 2022
Merged

feat: Added MinimumBreadcrumbLevel #1030

merged 8 commits into from
Oct 24, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Oct 20, 2022 •
edited
Loading

Resolves #1029

Because there is no inherent order to the log type and we're already transforming Unity LogType to Sentry LogType I added individual checkboxes to opt-out of adding breadcrumbs automatically.
Screenshot 2022-10-24 at 16 16 00

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner October 20, 2022 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cd1dee8

vaind
vaind requested changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it makes sense to do the partial solution. Would it be much more trouble to implement the real solution as described in #60 - that's a superset of this

@bitsandfoxes bitsandfoxes requested a review from vaind October 21, 2022 12:36
@bitsandfoxes bitsandfoxes changed the title feat: Added an opt-out for adding logs as breadcrumbs feat: Added MinimumBreadcrumbLevel Oct 21, 2022
@bitsandfoxes bitsandfoxes requested a review from vaind October 24, 2022 15:53
vaind
vaind approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Sorry for being such a nuisance on the previous two versions

@vaind vaind merged commit 5a7cd66 into main Oct 24, 2022
@vaind vaind deleted the feat/log2breadcrumb-opt-out branch October 24, 2022 16:51
@bitsandfoxes
Copy link
Contributor Author

Looks great. Sorry for being such a nuisance on the previous two versions

You were absolutely right tho. It's much more usable this way.

@bitsandfoxes bitsandfoxes mentioned this pull request Oct 27, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a way to set log type that can be captured as a breadcrumb
3 participants
@bitsandfoxes @vaind @getsentry-bot