-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: seperate build & runtime scriptable options configure() #1046
Conversation
|
27c1b06
to
098d4a8
Compare
If we wanted to have this covered in integration test, we could use the WDYT @bitsandfoxes ? |
samples/unity-of-bugs/Assets/Resources/Sentry/CustomOptionsConfiguration.asset
Outdated
Show resolved
Hide resolved
That's a fantastic idea! |
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the not throwing this looks great to me!
We're gonna break all the people with this, aren't we?
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
098d4a8
to
4468d5a
Compare
…ity won't compile scripts
4468d5a
to
3aecf9c
Compare
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pure 🔥 !
closes #609
ScriptableOptionsConfiguration
classPerformanceAutoInstrumentation
option withPerformanceAutoInstrumentationEnabled
and makes it part ofSentryUnityOptions
SetScript()
after a new custom configuration script is created through Editor window UIBuildtimeOptions.Configure()
andRuntimeOptions.Configure()