Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing Sentry.framework from being copied as ResourceBundle #1056

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix: Removing Sentry.framework from being copied as ResourceBundle #1056

merged 2 commits into from
Oct 28, 2022

Conversation

bitsandfoxes
Copy link
Contributor

This only came up when trying to distribute the app.
Screenshot 2022-10-28 at 11 15 40

Adding the .xcframework also added it to the Copy Bundle Resource phase where it does not belong.
Screenshot 2022-10-28 at 13 17 55

The change seems to be introduced with the switch to xcframework instead of a framework.

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner October 28, 2022 11:23
@bitsandfoxes bitsandfoxes merged commit 8128330 into main Oct 28, 2022
@bitsandfoxes bitsandfoxes deleted the fix/xcframework branch October 28, 2022 12:39
@bitsandfoxes bitsandfoxes mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitsandfoxes @vaind