Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip zeroes for ill2cpp builds #108

Merged
merged 8 commits into from
Apr 14, 2021
Merged

Conversation

semuserable
Copy link
Contributor

closes #103

@semuserable
Copy link
Contributor Author

@bruno-garcia license again..

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs some tests

@semuserable
Copy link
Contributor Author

@bruno-garcia test added

@semuserable
Copy link
Contributor Author

semuserable commented Apr 13, 2021

Seems there is a problem with nuget on build machine. @Tyrrrz can you take a look please?

@Tyrrrz
Copy link
Contributor

Tyrrrz commented Apr 13, 2021

@semuserable looks like an issue in GitHub Actions infrastructure, I see it throughout other projects as well.

According to this comment, it may be fixable if we add NuGet.config file to our solution:
actions/setup-dotnet#155 (comment)

@Tyrrrz Tyrrrz mentioned this pull request Apr 13, 2021
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Apr 13, 2021

@semuserable rebase on latest main please

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bruno-garcia bruno-garcia merged commit 0cdec0f into main Apr 14, 2021
@bruno-garcia bruno-garcia deleted the enchancement/ill2cpp-filename branch April 14, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IL2CPP doesn't have file name:
3 participants