Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Symbol upload logging for iOS #1091

Merged
merged 13 commits into from
Nov 28, 2022
Merged

fix: Symbol upload logging for iOS #1091

merged 13 commits into from
Nov 28, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Nov 24, 2022 •
edited
Loading

Resolves #1071

  • Forcing the symbol upload in the foreground to have the logs available in the Xcode console.
  • Removing the log level from the command because we write it into the .properties already
  • Removed note: because it was messing with the order of logs

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner November 24, 2022 10:57
@bitsandfoxes bitsandfoxes changed the title added logging and more fix: Symbol upload logging for iOS Nov 24, 2022
vaind
vaind approved these changes Nov 24, 2022
View reviewed changes
src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes requested a review from vaind November 28, 2022 13:33
@bitsandfoxes bitsandfoxes merged commit 40c9cdf into main Nov 28, 2022
@bitsandfoxes bitsandfoxes deleted the fix/ios-sym-upload branch November 28, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command PhaseScriptExecution emitted errors but did not return a nonzero exit code to indicate failure
2 participants
@bitsandfoxes @vaind