Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Option config script name #1146

Merged
merged 4 commits into from
Jan 20, 2023
Merged

fix: Option config script name #1146

merged 4 commits into from
Jan 20, 2023

Conversation

bitsandfoxes
Copy link
Contributor

The classes those option configs inherit from have the same name as the script that gets generated leading to compile time errors when they get created.

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner January 19, 2023 14:58
@vaind
Copy link
Collaborator

vaind commented Jan 19, 2023

LGTM but CI fails

@bitsandfoxes bitsandfoxes merged commit 49a0a71 into main Jan 20, 2023
@bitsandfoxes bitsandfoxes deleted the fix/optionsconfig branch January 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants