Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Setting the instruction_addr_adjustment for IL2CPP exceptions #1165

Merged
merged 12 commits into from
Feb 21, 2023
Merged

feat: Setting the instruction_addr_adjustment for IL2CPP exceptions #1165

merged 12 commits into from
Feb 21, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Based on getsentry/rfcs#43
Fixing C# line numbers for IL2CPP builds.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c149d31

@bitsandfoxes bitsandfoxes marked this pull request as ready for review February 10, 2023 13:48
@bitsandfoxes bitsandfoxes requested a review from vaind February 10, 2023 13:48
vaind
vaind reviewed Feb 11, 2023
View reviewed changes
src/Sentry.Unity/Il2CppEventProcessor.cs
Comment on lines +54 to +57
sentryStacktrace.AddressAdjustment =
Application.platform == RuntimePlatform.Android
? InstructionAddressAdjustment.None
: InstructionAddressAdjustment.All;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested other platforms with @Swatinem? This comment only mentioned Android, macOS and iOS: getsentry/rfcs#43 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have also tried Windows as well. Android seemed to be the only platform where the instruction addresses are already adjusted coming from Unity.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any info on Linux?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we have ever looked at that directly. @bitsandfoxes can you prepare an example? Given that all the other platforms are consistent across Unity versions, I believe its fine to only have one example.

Copy link
Contributor Author

@bitsandfoxes bitsandfoxes Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works as intended: https://sentry-sdks.sentry.io/issues/3910273139/events/338e29d9d91147fc88b73d29ca7dc3f8/?project=4504604988538880

@bitsandfoxes bitsandfoxes merged commit cddf083 into main Feb 21, 2023
@bitsandfoxes bitsandfoxes deleted the feat/instr-adr-adj branch February 21, 2023 13:20
This was referenced Feb 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem left review comments

@vaind vaind vaind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitsandfoxes @Swatinem @vaind