ci: Android build in a separate job #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vaind
commented
Mar 21, 2023
•
vaind
commented
- Enables android project export from Unity (for the integration test)
- fixes issues and some bugs present with that option
- I've also got a cool idea to move android retry logic to a separate workflow so we can actually retry the whole thing on a different runner, since if it failed once, it was likely to fail again on the same machine.
vaind
force-pushed
the
ci/android-build-changes
branch
23 times, most recently
from
95addad to
b3c4978
Compare
vaind
force-pushed
the
ci/android-build-changes
branch
from
c7af539 to
b603b0e
Compare
bitsandfoxes
approved these changes
Mar 29, 2023
| @@ -186,14 +186,15 @@ internal void SetupSymbolsUpload(string unityProjectPath, string gradleProjectPa | |||
| try | |||
| { | |||
| _logger.LogInfo("Adding automated debug symbols upload to the gradle project."); | |||
|
|
|||
| var sentryCliPath = SentryCli.SetupSentryCli(); | |||
| // TODO this currently copies the CLI for the current platform, thus making the exported project only | |||
There was a problem hiding this comment.
Fair point. I think this has not come up yet because iOS is the only odd one.
AFAIK, users export the Xcode project on platforms other than macOS and then use services to only build that one project.
There was a problem hiding this comment.
Yes, iOS is fine. This is only an issue with Android export.
vaind
force-pushed
the
ci/android-build-changes
branch
from
fb34bab to
2fdb4e7
Compare
Co-authored-by: Stefan Jandl <reg@bitfox.at>
Co-authored-by: Stefan Jandl <reg@bitfox.at>
vaind
force-pushed
the
ci/android-build-changes
branch
2 times, most recently
from
4758d4a to
4e28e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.