fix: Don't add Sentry Android with Android Native Support disabled
#1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
reviewed
Apr 3, 2023
src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
vaind
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base idea is to make unity games as a library work. For that, the SDK can't move any native SDK into the gradle output project.
That means the SDK no longer needs to set
self-init = falsein the manifest because there is no android SDK in the output projectgradleProject/unityLibrary/libsgradleProject/unityLibrary/build.gradle