Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter Web and SocketException #1294

Merged
merged 16 commits into from
May 11, 2023
Merged

fix: Filter Web and SocketException #1294

merged 16 commits into from
May 11, 2023

Conversation

bitsandfoxes
Copy link
Contributor

We're seeing a huge number of barely actionable events. They are being captured through the UnobservedTaskException mechanism but the stacktrace alone does not help with the System.Net.WebException and System.Net.Sockets.SocketException because the exception themselves don't have any information about the address they were trying to connect to.

Base automatically changed from fix/filter-badgateway to main April 26, 2023 09:27
@mattjohnsonpint
Copy link
Contributor

Is everything in this PR related to this change? Seems like maybe a bad merge?

@bitsandfoxes bitsandfoxes removed the request for review from vaind May 8, 2023 08:03
@vaind vaind merged commit 198985c into main May 11, 2023
@vaind vaind deleted the fix/filter-websocket branch May 11, 2023 08:37
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Filter `Web` and `SocketException` ([#1294](https://github.com/getsentry/sentry-unity/pull/1294))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 91bde12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants