Skip to content

chore(deps): update .NET SDK to v3.33.0 #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2023
Merged

chore(deps): update .NET SDK to v3.33.0 #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38d0be0
chore: update src/sentry-dotnet to 3.33.0
web-flow May 23, 2023
d2024d2
Format code
getsentry-bot May 23, 2023
522f7ef
'breaking' changes
bitsandfoxes May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
- Bump Native SDK from v0.6.1 to v0.6.2 ([#1308](https://github.com/getsentry/sentry-unity/pull/1308))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#062)
- [diff](https://github.com/getsentry/sentry-native/compare/0.6.1...0.6.2)
- Bump .NET SDK from v3.29.1 to v3.31.0 ([#1307](https://github.com/getsentry/sentry-unity/pull/1307))
- [changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md#3310)
- [diff](https://github.com/getsentry/sentry-dotnet/compare/3.29.1...3.31.0)
- Bump .NET SDK from v3.29.1 to v3.33.0 ([#1307](https://github.com/getsentry/sentry-unity/pull/1307), [#1331](https://github.com/getsentry/sentry-unity/pull/1331))
- [changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md#3330)
- [diff](https://github.com/getsentry/sentry-dotnet/compare/3.29.1...3.33.0)

## 1.2.0

Expand Down
2 changes: 1 addition & 1 deletion src/Sentry.Unity.Editor/Android/GradleSetup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ internal string InsertIntoScope(string gradleContent, string scope, string inser
{
startIndex += 1;
}

i = FindClosingBracket(lines, startIndex);
}
else if (lines[i].Contains(scope))
Expand Down
2 changes: 1 addition & 1 deletion src/sentry-dotnet
Open in desktop
Submodule sentry-dotnet updated 197 files
2 changes: 1 addition & 1 deletion test/Sentry.Unity.Tests/ScriptableSentryUnityOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void ToSentryUnityOptions_ValueMapping_AreEqual(bool isBuilding, bool ena
scriptableOptions.Dsn = expectedOptions.Dsn;
scriptableOptions.CaptureInEditor = expectedOptions.CaptureInEditor;
scriptableOptions.EnableLogDebouncing = expectedOptions.EnableLogDebouncing;
scriptableOptions.TracesSampleRate = expectedOptions.TracesSampleRate;
scriptableOptions.TracesSampleRate = (double)expectedOptions.TracesSampleRate;
scriptableOptions.AutoSessionTracking = expectedOptions.AutoSessionTracking;
scriptableOptions.AutoSessionTrackingInterval = (int)expectedOptions.AutoSessionTrackingInterval.TotalMilliseconds;
scriptableOptions.AttachStacktrace = expectedOptions.AttachStacktrace;
Expand Down
10 changes: 10 additions & 0 deletions test/Sentry.Unity.Tests/Stubs/TestHub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ public SentryId CaptureEvent(SentryEvent evt, Scope? scope = null)
return evt.EventId;
}

public SentryId CaptureEvent(SentryEvent evt, Hint? hint, Scope? scope = null)
{
throw new NotImplementedException();
}

public void CaptureUserFeedback(UserFeedback userFeedback)
{
throw new NotImplementedException();
Expand All @@ -33,6 +38,11 @@ public void CaptureTransaction(Transaction transaction)
{
}

public void CaptureTransaction(Transaction transaction, Hint? hint)
{
throw new NotImplementedException();
}

public void CaptureSession(SessionUpdate sessionUpdate)
{
}
Expand Down