Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Suspend Android native support on Mono #1362

Merged
merged 8 commits into from
Jun 10, 2023
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jun 7, 2023

"Fix" is a bit of a stretch. More like "disabling it to prevent crashes".
The support was enabled with 0.18.0 and works for throwing Exceptions. But actually triggering a NullReferenceException i.e.

// Ends up on sentry-native and crashes the game
public void Start()
{
    TextAsset text = null;
    var bytes = text.bytes;
}

// Does not crash
public void Start()
{
    throw null;
}

// Does not crash
public void Start()
{
    throw new NullReferenceException();
}

ends up on the signal handler, ending up in sentry-native and causing the app to crash due to a C# exception.

@bitsandfoxes bitsandfoxes changed the title Fix: Android native support on Mono Fix: Suspend Android native support on Mono Jun 7, 2023
@bitsandfoxes bitsandfoxes requested a review from vaind June 9, 2023 11:42
@vaind vaind merged commit 8d5fc01 into main Jun 10, 2023
@vaind vaind deleted the fix/mono-android-native branch June 10, 2023 11:03
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Suspend Android native support on Mono ([#1362](https://github.com/getsentry/sentry-unity/pull/1362))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a51ef86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants