feat: Surface options to opt out of the Android NDK integration
#1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Surface options to opt out of the Android `NDK integration` ([#1452](https://github.com/getsentry/sentry-unity/pull/1452))If none of the above apply, you can opt out of this check by adding |
cleptric
reviewed
Sep 26, 2023
Comment on lines
+157
to
+166
| /// <summary> | ||
| /// Whether the SDK should add the NDK integration for Android | ||
| /// </summary> | ||
| public bool NdkIntegrationEnabled { get; set; } = true; | ||
|
|
||
| /// <summary> | ||
| /// Whether the SDK should sync the scope to the NDK layer for Android | ||
| /// </summary> | ||
| public bool NdkScopeSyncEnabled { get; set; } = true; | ||
|
|
There was a problem hiding this comment.
Can I use either or, or do they depend on each other?
There was a problem hiding this comment.
NdkIntegrationEnabled completely disabled the NDK integration.
NdkScopeSyncEnabled enabled the scope sync if the NDK integration has been enabled.
The editor window reflects that:
cleptric
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: getsentry/sentry-java#2955
Gives more granular control over the Android native support by allowing to disable the NDK integration.
Added an opt-out for scope sync while at it.