fix: remove ios embed framework build phase duplication (#1558)

[munkiki7]

The linking phase is still added multiple times, but I could not find a way to check if it is already added.
But this does not break the build.

[bitsandfoxes]

The linking phase is still added multiple times, but I could not find a way to check if it is already added.

Can't we just check for one of the things we do (i.e. adding the framework) and bail early instead of linking it twice?

[munkiki7]

The linking phase is still added multiple times, but I could not find a way to check if it is already added.

Can't we just check for one of the things we do (i.e. adding the framework) and bail early instead of linking it twice?

This is a completely separate point, so, for example, if the user builds, then opens the XCode project, and deletes the link task, and builds again, it won't be added. This is a low-probability case, and a clean build will fix it.

So, do you want me to leave it as is, or do only one check for framework and linking as you have proposed?

[bitsandfoxes]

This is a completely separate point, so, for example, if the user builds, then opens the XCode project, and deletes the link task, and builds again, it won't be added. This is a low-probability case, and a clean build will fix it.

I think this is very much self-inflicted then and we're good.

[bitsandfoxes]

Thanks!

[github-actions]

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- remove ios embed framework build phase duplication (#1558) ([#1595](https://github.com/getsentry/sentry-unity/pull/1595))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5807875