Fix/android improvements 1599 #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
munkiki7
commented
Apr 16, 2024
munkiki7
commented
- add custom callback order for PostGeneratedGradle callback
- make sentry gradle additions logic more reliable
added 6 commits
March 27, 2024 15:27
…dle project script (#1411)
Comment on lines
13
to
16
| dependencies { | ||
| implementation(name: 'sentry-android-ndk-release', ext:'aar') | ||
| implementation(name: 'sentry-android-core-release', ext:'aar') | ||
| } |
There was a problem hiding this comment.
TIL that there can be multiple dependencies blocks!
src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Jandl <reg@bitfox.at>
bitsandfoxes
approved these changes
Apr 18, 2024
|
Looking great! Thanks! 🔥 |
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.