Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scene manager integration #170

Merged
merged 5 commits into from
May 13, 2021
Merged

Conversation

bruno-garcia
Copy link
Member

Currently breadcrumbs.

I haven't tested this on a game with scenes so I'm not sure if it makes sense to add crumbs for the 3 events.
Does the Active Scene one always trigger one either Load or Unload kicks off?

We can also use this, hopefully to get timing info (spans) and perhaps track metrics too.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- scene manager integration ([#170](https://github.com/getsentry/sentry-unity/pull/170))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against c6db254

@bruno-garcia bruno-garcia merged commit 95ec8fa into main May 13, 2021
@bruno-garcia bruno-garcia deleted the feat/scene-manager-integration branch May 13, 2021 04:39
@bruno-garcia
Copy link
Member Author

Merged by accident.

It does fire for both btw:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant