-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition scene to test scene loading events (breadcrumbs) #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have multiple scenes we could rename them to BugFarmLevel_1 / Level_2 respectively. Other than us noone knows what a "TransitionScene" is and what it's for. With the numeric postfix there is an implied hierarchy that helps with self documenting.
This is nitpicking but please reset the transform on the TransitionScene/Scripts GameObject. |
I have no strict preference to naming the scenes, but I prefer to give descriptive names. "Us" is developers who develop the package, so "we" understand what "TransitionScene" means. We can also document it. |
But it's not just "us developers" who get to see and use it, right? We ship it as sample with our package to users. And they should not need to read the documentation to know which scene is the first they should want to open. |
As I was saying, I have no strong preference about scene namings. If in Unity community it's better to name scenes like Level_n, then sure, let's do that. |
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
TransitionScene
with two buttons: loadBugFarmScene
andThrowNull
.BugFarmScene
Now can test load scene events.