-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Embedded link.xml in assembly #194
Conversation
[Test] | ||
public void LinkXml_Embedded() | ||
{ | ||
var resourceNames = Assembly.GetAssembly(typeof(SentryUnity)).GetManifestResourceNames(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the proper way to get to the assembly so any feedback would be greatly appreciated.
Does Unity support this? |
Yes they do! https://forum.unity.com/threads/the-current-state-of-link-xml-in-packages.995848/ <- last reply point a) |
@bitsandfoxes if you remove link.xml completely, does it fail to capture? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great find btw! Much nicer way to manage the link.xml
It does not even compile if the file is missing. You'd have to remove it from the csproj and then it doesn't show up on the manifest and then the test fails. |
Instead of having to copy the link.xml into Assets/ we can embed the file into the assembly.
https://sentry.io/organizations/sentry-sdks/issues/2410989926/?project=5439417&query=is%3Aunresolved