Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: default & serialization #220

Merged
merged 28 commits into from
Jun 23, 2021
Merged

Config: default & serialization #220

merged 28 commits into from
Jun 23, 2021

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jun 9, 2021

Two main goals:

  1. Set default values at the appropriate time
  2. Set up a user-facing options object to deal with overrides and other limitations (i.e. serialization)

I created a new class for the user-facing options object and decided to go with unity's scriptable object. That way we completely avoid any serialization/deserialization on our part + it's editable in the inspector (if we choose to support that).

@bitsandfoxes bitsandfoxes added the Feature New feature or request label Jun 9, 2021
@bitsandfoxes bitsandfoxes self-assigned this Jun 9, 2021
@bitsandfoxes bitsandfoxes changed the title Feat: Config default & serialization Config: default & serialization Jun 14, 2021
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/JsonSentryUnityOptions.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/JsonSentryUnityOptions.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/ScriptableSentryUnityOptions.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/ScriptableSentryUnityOptions.cs Outdated Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass

src/Sentry.Unity.Editor/SentryTestWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/JsonSentryUnityOptions.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes marked this pull request as ready for review June 18, 2021 16:31
src/Sentry.Unity.Editor/SentryTestWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/IntegrationTests.cs Show resolved Hide resolved
test/Sentry.Unity.Tests/UnitySentryOptionsTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/UnitySentryOptionsTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/UnitySentryOptionsTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/UnitySentryOptionsTests.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/IntegrationTests.cs Show resolved Hide resolved
test/Sentry.Unity.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
test/Sentry.Unity.Tests/UnitySentryOptionsTests.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Show resolved Hide resolved
src/Sentry.Unity/JsonSentryUnityOptions.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryInitialization.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryInitialization.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants