Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release health integration & Event-listener #225

Merged
merged 28 commits into from
Jun 25, 2021
Merged

Release health integration & Event-listener #225

merged 28 commits into from
Jun 25, 2021

Conversation

bitsandfoxes
Copy link
Contributor

So we can hook into Monobehaviour-Events like OnApplicationPause e.t.c.
Adds an invisible GameObject with the GameEventListener component to the active scene.

bruno-garcia
bruno-garcia reviewed Jun 11, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem pretty elegant to me. I'll give this a try with the release health stuff on Monday!

@bitsandfoxes bitsandfoxes self-assigned this Jun 14, 2021
@bruno-garcia bruno-garcia changed the title POC: Release health integration & Event-listener Release health integration & Event-listener Jun 14, 2021
@bruno-garcia bruno-garcia mentioned this pull request Jun 15, 2021
Closed
bruno-garcia
bruno-garcia reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Just the ideas we discussed on a call

src/Sentry.Unity/GameEventListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/GameEventListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/GameEventListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/GameEventListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/Integrations/ITime.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/Integrations/ReleaseHealthIntegration.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/Integrations/ReleaseHealthIntegration.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryUnity.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryUnityOptions.cs Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia marked this pull request as ready for review June 18, 2021 16:08
@bruno-garcia bruno-garcia marked this pull request as draft June 18, 2021 16:08
@bruno-garcia bruno-garcia marked this pull request as ready for review June 23, 2021 22:03
@bitsandfoxes bitsandfoxes added the Feature New feature or request label Jun 24, 2021
bruno-garcia
bruno-garcia approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

src/Sentry.Unity/ApplicationPauseListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/ApplicationPauseListener.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryOptionsUtility.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 973d44b into main Jun 25, 2021
@bitsandfoxes bitsandfoxes deleted the feat/release-health-listener branch June 25, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@semuserable semuserable semuserable approved these changes

Assignees

@bitsandfoxes bitsandfoxes

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitsandfoxes @bruno-garcia @semuserable