chore: Create iOS-only xcframework in CI
#2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…etsentry/sentry-unity into chore/create-xcframework-in-ci
vaind
approved these changes
Aug 6, 2025
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2260
Relates to #2161
Relates to getsentry/sentry-cocoa#5740
"Fixes" Signing Issue
Starting with
8.52.0the Cocoa SDK comes with code signing. This relies on symlinks. This will not work as expected with the way we ship the Unity SDK - i.e. export an Xcode project on Windows, build it on macOS.Wombo-Combo-"Solution": We're now creating an
ios-onlyxcframework out of the downloaded artifact. Doing this makes the resulting bundle a lot smaller and it also gets rid of the code signing."Build" the Cocoa SDK in CI
Since the
ios-onlyxcframework creation relies onxcodebuildthis needs to happen on a macOS runner. I've added the "building" of the Cocoa SDK back tosdk.ymlat treat is like the other native SDKs.We wanted to get the ability to build from a submodule anyway - see In #2161 - and that's half a step in that direction.
Outcome
Looks like we're going down from
~412MBto~42MB.We're no longer running into signing issues since the "rebuild" removes it.