Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unity protocol #234

Merged
merged 13 commits into from
Jun 23, 2021
Merged

Unity protocol #234

merged 13 commits into from
Jun 23, 2021

Conversation

semuserable
Copy link
Contributor

@semuserable semuserable commented Jun 22, 2021 •
edited
Loading

closes #49

WIP

bruno-garcia
bruno-garcia reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good for a draft btw

src/Sentry.Unity/UnityEventProcessor.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/UnityEventProcessor.cs Outdated Show resolved Hide resolved
@semuserable semuserable marked this pull request as ready for review June 23, 2021 07:09
@semuserable
Copy link
Contributor Author

semuserable commented Jun 23, 2021 •
edited
Loading

I think we should probably add SystemInfo.graphicsShaderLevel on IApplication level so we can unit test the conversion logic.

What do you think @bruno-garcia?

@semuserable
Copy link
Contributor Author

Ready to be reviewed.

cc @bruno-garcia @bitsandfoxes

@bruno-garcia bruno-garcia merged commit 947e44e into main Jun 23, 2021
@bruno-garcia bruno-garcia deleted the feature/unity-protocol branch June 23, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Unity Context
2 participants
@semuserable @bruno-garcia